Skip to content

Remove support for v0.2 v0.1 events #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grant opened this issue May 27, 2020 · 6 comments
Closed

Remove support for v0.2 v0.1 events #35

grant opened this issue May 27, 2020 · 6 comments
Assignees

Comments

@grant
Copy link
Member

grant commented May 27, 2020

The SDK spec states we don't have to support v0.2 v0.1 versions. We should remove support and document current support here.

@grant
Copy link
Member Author

grant commented May 29, 2020

It's not required and these versions are seldomly used since 1.0 came out.

@di
Copy link
Member

di commented Jun 19, 2020

I don't see why we need to intentionally create breaking changes for end users. I think I'd prefer saying the new "pythonic" API only supports v1 and v0.3 and that eventually when we deprecate the old API, we'll remove it entirely, including support for these versions.

@cumason123
Copy link
Contributor

Seems reasonable. I'm going to remove my existing PR and instead change sample code and README to using v1/v03 classes

@grant
Copy link
Member Author

grant commented Jun 19, 2020

@di 0.1, 0.2 events are strictly not required to be supported according to the spec.
https://github.com/cloudevents/spec/blob/master/SDK.md

This is common amongst other SDKs.
Besides, there are very few event producers that use < 1.0 events.

Previous publications can be used by existing users if they need this support.

It should be OK to remove these event versions like we've done so for other language SDKs.

@di
Copy link
Member

di commented Jun 22, 2020

OK, looks like this happened anyways.

Please update CHANGELOG.md to indicate to users that this is removed in the future version. This wasn't done in #43, I didn't have an opportunity to review that PR.

@grant
Copy link
Member Author

grant commented Jun 22, 2020

Yes, I merged the PR as it aligns with other language SDKs and the spec.

Looking for a review on #36 before continuing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants