Skip to content

fix: to_json breaking change #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sasha-tkachev
Copy link
Contributor

@sasha-tkachev sasha-tkachev commented Aug 22, 2022

Fixes #190

Changes

Add missing to_json import

One line description for the changelog

  • Tests pass
  • Appropriate changes to README are included in PR

sasha-tkachev and others added 5 commits August 23, 2022 01:34
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Copy link
Member

@xSAVIKx xSAVIKx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for taking care of this. Please bump the version of the module and also add the respective section in the changelog

@@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the 1.6.1 release section and also update the version in the module init.py

Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
@sasha-tkachev sasha-tkachev requested a review from xSAVIKx August 24, 2022 21:13
@xSAVIKx xSAVIKx merged commit eba24db into cloudevents:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking Changes introduced in version 1.6.0
2 participants