-
Notifications
You must be signed in to change notification settings - Fork 58
Updates for binary encoding #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update marshaller to handle both structured and binary formats. Signed-off-by: Evan Anderson <evan.k.anderson@gmail.com>
319a3f4
to
0a59dd7
Compare
Signed-off-by: Evan Anderson <evan.k.anderson@gmail.com>
Signed-off-by: Evan Anderson <evan.k.anderson@gmail.com>
The python program I wrote: https://github.com/evankanderson/docs/tree/message-dumper/eventing/samples/message-dumper (No readme or the like right now, and still some debugging/commented information from diagnosing this issue.) |
@evankanderson can you please merge this PR with #7? I'd like to get them into altogether. |
I'm happy to rebase on top of #7 when it is submitted, if that will be
submitted something soon.
…On Sat, Jan 12, 2019, 9:24 AM Denis Makogon ***@***.***> wrote:
@evankanderson <https://github.com/evankanderson> can you please merge
this PR with #7 <#7>,
please? I'd like to get them into altogether.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHlyN5aZ3Wj9KhQJdy2MoYEIuPokNZiqks5vChoygaJpZM4Z8p0m>
.
|
can you close this PR and merge commits from this branch to PR #7, please? I'd be happy to release a new version of an SDK early next week. |
Updates binary encoding to handle extensions and content-type per spec.
Update marshaller to handle both structured and binary formats. Previously, it would try structured first, even if the content-type did not match, and then ignore all the headers, producing very wimpy events with no data.
Link to issue this resolves
I was too lazy to file an issue while debugging.
What I did
I wrote a small python program using Flask to log cloud events, and to report them in a webpage. I'll be putting in in a pull request to https://github.com/knative/docs soon.
How I did it
I used the following command to POST cloudevents to the flask program I wrote above.
How to verify it
I updated the tests.
One line description for the changelog