Skip to content

Upgrade to 1.0.1 breaks my app #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
awendt opened this issue Nov 8, 2016 · 4 comments
Closed

Upgrade to 1.0.1 breaks my app #146

awendt opened this issue Nov 8, 2016 · 4 comments

Comments

@awendt
Copy link

awendt commented Nov 8, 2016

I just upgraded from 0.6.0 to 1.0.1 in an app. Because the dependency on simplecov was turned into a dev dependency in #121, I now get this error:

$APP/vendor/$BLA/gems/codeclimate-test-reporter-1.0.1/lib/code_climate/test_reporter/formatter.rb:7:in `require': cannot load such file -- simplecov (LoadError)

because the formatter still requires simplecov 😢
@mbusch
Copy link

mbusch commented Nov 8, 2016

You should check the updated doc before filing an issue.

@awendt
Copy link
Author

awendt commented Nov 8, 2016

@mbusch Thanks for the quick response. Admittedly, I wasn't looking.

@dblandin
Copy link
Contributor

dblandin commented Nov 8, 2016

Hey @awendt,

I think you're right about the simplecov dependency. We no longer inject behavior into the SimpleCov test coverage process, but we still rely upon SimpleCov within the reporter, so it should be promoted from a dev dependency to a gem dependency.

maxjacobson added a commit that referenced this issue Nov 8, 2016
@maxjacobson
Audit and organize dependencies
8f5f068 
* move development dependencies to Gemfile
* use bundler's platform directive to specify ruby version dependency
  differences
* promote SimpleCov to a runtime depenency

Inspired by:

* a0e5d03#commitcomment-19735625
* #146 (comment)
@maxjacobson maxjacobson mentioned this issue Nov 8, 2016
Merged
maxjacobson added a commit that referenced this issue Nov 8, 2016
@maxjacobson
Audit and organize dependencies
d92eceb 
* Promote SimpleCov to a runtime depenency
* Extract ruby 1.9 dependencies to separate Gemfile

Inspired by:

* a0e5d03#commitcomment-19735625
* #146 (comment)
maxjacobson added a commit that referenced this issue Nov 9, 2016
@maxjacobson
Audit and organize dependencies
2b45306 
* Promote SimpleCov to a runtime depenency
* Extract ruby 1.9 dependencies to separate Gemfile

Inspired by:

* a0e5d03#commitcomment-19735625
* #146 (comment)
maxjacobson added a commit that referenced this issue Nov 9, 2016
@maxjacobson
Audit and organize dependencies
5fe6fdd 
* Promote SimpleCov to a runtime depenency
* Extract ruby 1.9 dependencies to separate Gemfile

Inspired by:

* a0e5d03#commitcomment-19735625
* #146 (comment)
maxjacobson added a commit that referenced this issue Nov 9, 2016
@maxjacobson
Audit and organize dependencies
43b167a 
* Promote SimpleCov to a runtime depenency
* Extract ruby 1.9 dependencies to separate Gemfile

Inspired by:

* a0e5d03#commitcomment-19735625
* #146 (comment)
maxjacobson added a commit that referenced this issue Nov 9, 2016
@maxjacobson
Audit and organize dependencies (#148)
3252bb7 
* Promote SimpleCov to a runtime depenency
* Extract ruby 1.9 dependencies to separate Gemfile

Inspired by:

* a0e5d03#commitcomment-19735625
* #146 (comment)
@maxjacobson maxjacobson mentioned this issue Nov 9, 2016
Merged
@maxjacobson
Copy link
Contributor

@awendt just released 1.0.3 which includes simplecov as a dependency, which should prevent this LoadError. Thanks for creating the issue to let us know about it!

@awendt awendt changed the title Upgrate to 1.0.1 breaks my app Upgrade to 1.0.1 breaks my app Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@awendt @dblandin @mbusch @maxjacobson