Audit and organize dependencies #148
Conversation
| gem "rake" | ||
| gem "rspec" | ||
| gem "webmock" | ||
| gem "pry" |
There was a problem hiding this comment.
I'd prefer to keep these dependencies within the gemspec.
Ideally, this file would only contain two lines:
source "http://www.rubygems.org"
gemspecThere was a problem hiding this comment.
Sorry, I didn't see this thread before commenting: a0e5d03#commitcomment-19735625
Still thinking about how to manage this...
e1ce959 to
2b45306
Compare
|
@dblandin this is ready for another look |
| @@ -0,0 +1,19 @@ | |||
| #!/bin/bash --login | |||
There was a problem hiding this comment.
What do you think of using the more portable #!/usr/bin/env bash shebang form?
There was a problem hiding this comment.
I like it, updating
There was a problem hiding this comment.
Ah, it didn't work: https://circleci.com/gh/codeclimate/ruby-test-reporter/133 and I undid it. I think the loss in portability is a thing, but not a huge thing, because we don't change CI services that often... WDYT?
There was a problem hiding this comment.
Works for me. Why is --login needed?
There was a problem hiding this comment.
rvm use didn't work without it in an earlier permutation. Just double checked: https://circleci.com/gh/codeclimate/ruby-test-reporter/135 and still think it's needed for the ruby switching to work
| bundle install --gemfile Gemfile.ruby-19 | ||
| bundle exec rake | ||
|
|
||
| set +x |
There was a problem hiding this comment.
Should we specify set -ex at the top instead of switching back and forth?
There was a problem hiding this comment.
Agreed it's a bit awkward. rvm use prints a ton of output (sample build: https://circleci.com/gh/codeclimate/ruby-test-reporter/130) so it seemed worthwhile to do this toggling dance to make the output more readable
Could just do set -e without the x, but I think we want it to make it more clear which step failed.... WDYT?
There was a problem hiding this comment.
Ahh, that is a lot of output. I might just leave debug off then. We'll still get the stderr output, if there is any.
|
A couple minor comments. LGTM otherwise. |
2b45306 to
5fe6fdd
Compare
* Promote SimpleCov to a runtime depenency * Extract ruby 1.9 dependencies to separate Gemfile Inspired by: * a0e5d03#commitcomment-19735625 * #146 (comment)
5fe6fdd to
43b167a
Compare
hopefully when tests fail it will be clear from stderr output which ruby versions suite failed. I may need to return --login... some earlier rvm output encouraged me to switch from #!/bin/sh to #!/bin/bash --login But maybe bash would've been sufficient
|
👌 |
differences
Inspired by:
@codeclimate/review @dblandin