-
Notifications
You must be signed in to change notification settings - Fork 568
angular-ui-bootstrap-bower
should not be a dependency
#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If I do not add it in bower.json then you can not run the demos locally unless you manually resolve |
I have an app without bootstrap and my build scripts automatically include all bower dependencies (https://github.com/yeoman/generator-angular). This means that bootstrap UI is loaded into my app although it is not needed which breaks some components in the UI. I had to manually delete |
Broke my build as well, because that particular dependency caused conflicts with the angular version. It uses angular < 1.3 instead of the 1.3.X series. Make it a dev dependency? |
@domoritz and @mtraynham guys, let me know if it works for you. |
I would have left the other dependencies in the |
The |
Not sure I follow. Say I have an empty project and I want my first dependency to be The It is important for you to specify dependencies though as I may use angular 1.1.X and this library only supports 1.3.X (just an example). As of that last change, I now have to include jquery-ui in my own bower. |
Fully agree with @mtraynham. The only problem for my deployment was bootstrap. Without jquery and jqueryui as a dependency, dragdrop doesn't work. |
Context: codef0rmer#145 angular and jquery ui are required dependencies but bootstrap is only needed for the demo. jqueryui already depends on jquery.
…ootstrap as devDependencies for the demos to work
Makes sense! |
@codef0rmer are you making a new release? |
@domoritz Yes. |
Sweet. I shouldn't be so impatient ;-) |
@domoritz hehe, done. |
I think this is used for the demos but it installs some dependencies that are not needed.
The text was updated successfully, but these errors were encountered: