Skip to content

angular-ui-bootstrap-bower should not be a dependency #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
domoritz opened this issue Jan 4, 2015 · 13 comments
Closed

angular-ui-bootstrap-bower should not be a dependency #145

domoritz opened this issue Jan 4, 2015 · 13 comments

Comments

@domoritz
Copy link
Contributor

domoritz commented Jan 4, 2015

I think this is used for the demos but it installs some dependencies that are not needed.

@codef0rmer
Copy link
Owner

If I do not add it in bower.json then you can not run the demos locally unless you manually resolve angular-ui-bootstrap dependency. Why do you think it's wrong?

@domoritz
Copy link
Contributor Author

domoritz commented Jan 5, 2015

I have an app without bootstrap and my build scripts automatically include all bower dependencies (https://github.com/yeoman/generator-angular). This means that bootstrap UI is loaded into my app although it is not needed which breaks some components in the UI. I had to manually delete angular-ui-bootstrap from the package.json which will of course break if somebody else downloads the code for my app and installs the bower components.

@mtraynham
Copy link

Broke my build as well, because that particular dependency caused conflicts with the angular version. It uses angular < 1.3 instead of the 1.3.X series. Make it a dev dependency?

@codef0rmer
Copy link
Owner

@domoritz and @mtraynham guys, let me know if it works for you.

@mtraynham
Copy link

I would have left the other dependencies in the dependencies section as they are requirements for this library. The angular-ui-bootstrap-bower dependency is only for this repo and demo purposes, thus it shouldn't be a requirement for an end-user to install. Also, there is a more supported version of angular-ui-bootstrap-bower which is just angular-ui-bootstrap.

@codef0rmer
Copy link
Owner

The bower install angular-dragdrop command unnecessarily installs other dependencies in your project under bower_components/, now it will not because of devDependencies. And nobody needs angular-dragdrop's dependencies in production.

@mtraynham
Copy link

Not sure I follow. Say I have an empty project and I want my first dependency to be angular-dragdrop. So, I type bower install angular-dragdrop. If I was an ignorant user or used wiredep, this would only attach angular-dragdrop to the index page. angular nor jquery wouldn't be downloaded or attached because you didn't specify them as dependencies.

The angular-ui-bootstrap-bower is not a dependency for the end user, it is only a dev-dependency to showcase a running demo. Follow?

It is important for you to specify dependencies though as I may use angular 1.1.X and this library only supports 1.3.X (just an example).

As of that last change, I now have to include jquery-ui in my own bower.

@domoritz
Copy link
Contributor Author

domoritz commented Jan 5, 2015

Fully agree with @mtraynham. The only problem for my deployment was bootstrap. Without jquery and jqueryui as a dependency, dragdrop doesn't work.

domoritz added a commit to domoritz/angular-dragdrop that referenced this issue Jan 5, 2015
Context: codef0rmer#145
angular and jquery ui are required dependencies but bootstrap is only needed for the demo. jqueryui already depends on jquery.
codef0rmer pushed a commit that referenced this issue Jan 6, 2015
…ootstrap as devDependencies for the demos to work
@codef0rmer
Copy link
Owner

Makes sense!

@domoritz
Copy link
Contributor Author

domoritz commented Jan 6, 2015

@codef0rmer are you making a new release?

@codef0rmer
Copy link
Owner

@domoritz Yes.

@domoritz
Copy link
Contributor Author

domoritz commented Jan 6, 2015

Sweet. I shouldn't be so impatient ;-)

@codef0rmer
Copy link
Owner

@domoritz hehe, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants