chore: add all missing tests for backstage-plugin-coder #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
commented
Mar 29, 2024
Comment on lines
+109
to
+111
| <h3 hidden id={formHeaderId}> | ||
| Authenticate with Coder | ||
| </h3> |
There was a problem hiding this comment.
This was missing from the component before – has two purposes:
- Increasing accessibility for the overall form
- Providing another way to hook into the component during testing
Parkreiner
commented
Mar 29, 2024
Comment on lines
133
to
149
| it('Will not show any workspaces at all when the query text is empty', async () => { | ||
| await renderWorkspacesCard({ readEntityData: true }); | ||
|
|
||
| const user = userEvent.setup(); | ||
| const inputField = await screen.findByRole('searchbox', { | ||
| name: /Search your Coder workspaces/i, | ||
| }); | ||
|
|
||
| await user.tripleClick(inputField); | ||
| await user.keyboard('[Backspace]'); | ||
|
|
||
| const emptyState = await screen.findByText( | ||
| /Use the search bar to find matching Coder workspaces/, | ||
| ); | ||
|
|
||
| expect(emptyState).toBeInTheDocument(); | ||
| }); |
There was a problem hiding this comment.
Hoping we can get rid of this test pretty quickly, but while this behavior is in the codebase, it felt better to assure that it was working reliably
Parkreiner
commented
Mar 29, 2024
Comment on lines
+71
to
+72
| await waitFor(() => expect(result.current.status).toBe('success')); | ||
| expect(result.current.data?.length).toBe(2); |
There was a problem hiding this comment.
With the updated test helpers, I don't think the old comment applies anymore
Kira-Pilot
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
Changes made
CoderWorkspacesCarduseCoderWorkspacesQueryNotes
There is one more behavior that could use a test, but I'm not sure if it's worth it. Basic steps are:
I was running into this when I was logged into the Full-stack challenge account, but had a token loaded for my personal Coder account. I think there is a way to simulate this at least, but: