Skip to content

docs: Update README to point to code-server docs site #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

BrunoQuaresma
Copy link
Contributor

No description provided.

@BrunoQuaresma BrunoQuaresma requested a review from bpmct June 28, 2021 14:34
@BrunoQuaresma BrunoQuaresma self-assigned this Jun 28, 2021
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner June 28, 2021 14:34
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #3684 (46a6f54) into main (4a47ce7) will not change coverage.
The diff coverage is n/a.

❗ Current head 46a6f54 differs from pull request most recent head 3856527. Consider uploading reports for the commit 3856527 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3684   +/-   ##
=======================================
  Coverage   59.87%   59.87%           
=======================================
  Files          35       35           
  Lines        1797     1797           
  Branches      364      364           
=======================================
  Hits         1076     1076           
  Misses        605      605           
  Partials      116      116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a47ce7...3856527. Read the comment docs.

Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

docs/README.md Outdated
@@ -26,7 +26,7 @@ You can use whatever linux distribution floats your boat but in our [guide](./gu
There are three ways you can get started:

1. Using the [install script](https://github.com/cdr/code-server/blob/main/install.sh), which automates most of the process. The script uses the system package manager (if possible)
2. Manually installing code-server; see [Installation](./install.md) for instructions applicable to most use cases
2. Manually installing code-server; see [Installation](https://coder.com/docs/code-server/latest/install) for instructions applicable to most use cases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsjoeio as a part of the release process, do you still do a bulk find and replace to increment the version number in any docs?

If so, I think we should replace latest with the version number in this case actually so that old docs will link to the correct branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question! Yes, that happens here.

If so, I think we should replace latest with the version number in this case actually so that old docs will link to the correct branch

Makes sense to me!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is quite hard to understand what is happening on this line and when I try to run that locally, after comment the send a PR step, I get an error:

xargs: sd: No such file or directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why sd is being used here... thoughts?

Copy link
Contributor Author

@BrunoQuaresma BrunoQuaresma Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed latest to use 3.10.2 so the current script are able to replace it. I tested it locally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a second...I should clarify. You (@BrunoQuaresma) don't need to run that script. That's only used when someone needs to prep a release. I was only pointing that out to show the logic.

All you need to do is update the link Ben pointed out to use the version (3.10.2) (which sounds like you did and tested, thank you ♥️)

I don't know why sd is being used here... thoughts?

Apologies - I could have sworn I added a check and explanation for it in this file but I guess I forgot. sd is a replacement for sed written in Rust that has a friendly API. See docs.

@bpmct bpmct requested a review from jsjoeio June 28, 2021 15:04
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two requests:

  • rebase with main (this will fix CI)
  • address @bpmct's comment about the installation link

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks for doing this Bruno! Let me know when you want me to merge (or you can I think?)

@BrunoQuaresma BrunoQuaresma merged commit 6dbabc0 into main Jun 29, 2021
@BrunoQuaresma BrunoQuaresma deleted the update-docs-links branch June 29, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants