-
Notifications
You must be signed in to change notification settings - Fork 5.9k
docs: Update README to point to code-server docs site #3684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3684 +/- ##
=======================================
Coverage 59.87% 59.87%
=======================================
Files 35 35
Lines 1797 1797
Branches 364 364
=======================================
Hits 1076 1076
Misses 605 605
Partials 116 116 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay!
docs/README.md
Outdated
@@ -26,7 +26,7 @@ You can use whatever linux distribution floats your boat but in our [guide](./gu | |||
There are three ways you can get started: | |||
|
|||
1. Using the [install script](https://github.com/cdr/code-server/blob/main/install.sh), which automates most of the process. The script uses the system package manager (if possible) | |||
2. Manually installing code-server; see [Installation](./install.md) for instructions applicable to most use cases | |||
2. Manually installing code-server; see [Installation](https://coder.com/docs/code-server/latest/install) for instructions applicable to most use cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsjoeio as a part of the release process, do you still do a bulk find and replace to increment the version number in any docs?
If so, I think we should replace latest
with the version number in this case actually so that old docs will link to the correct branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question! Yes, that happens here.
If so, I think we should replace latest with the version number in this case actually so that old docs will link to the correct branch
Makes sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is quite hard to understand what is happening on this line and when I try to run that locally, after comment the send a PR step, I get an error:
xargs: sd: No such file or directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why sd is being used here... thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed latest to use 3.10.2 so the current script are able to replace it. I tested it locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait a second...I should clarify. You (@BrunoQuaresma) don't need to run that script. That's only used when someone needs to prep a release. I was only pointing that out to show the logic.
All you need to do is update the link Ben pointed out to use the version (3.10.2) (which sounds like you did and tested, thank you
I don't know why sd is being used here... thoughts?
Apologies - I could have sworn I added a check and explanation for it in this file but I guess I forgot. sd
is a replacement for sed
written in Rust that has a friendly API. See docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two requests:
- rebase with
main
(this will fix CI) - address @bpmct's comment about the installation link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Thanks for doing this Bruno! Let me know when you want me to merge (or you can I think?)
No description provided.