fix: state collision #4881
Merged
fix: state collision #4881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has problems similar to the menu except instead of closing it gets re-created which interrupts the hover call and causes the test to fail. Now it will keep trying just like the menu.
code-asher
commented
Feb 17, 2022
039d367 to
404bee3
Compare
This contains the colliding state fix.
cea1df0 to
2dad878
Compare
Codecov Report
@@ Coverage Diff @@
## main #4881 +/- ##
=======================================
Coverage ? 69.79%
=======================================
Files ? 29
Lines ? 1649
Branches ? 363
=======================================
Hits ? 1151
Misses ? 424
Partials ? 74 Continue to review full report at Codecov.
|
|
Docs preview should be fixed: just waiting on a review for this 😉 #4875 |
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
* Add helper for navigating the quick picker This has problems similar to the menu except instead of closing it gets re-created which interrupts the hover call and causes the test to fail. Now it will keep trying just like the menu. * Add a test for opening a file * Add test for colliding state * Update VS Code This contains the colliding state fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code names their databases after the workspace but if two workspaces share the same path (for example if they are on different virtual machines) but they share the same domain (since IndexedDB is scoped to domain) then those two states will have a naming collision.
Blocked on coder/vscode#46.