Make unique database per location #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes collisions where VS Code is serving a workspace with the same name but on a different machine and hosted on the same domain.
|
Another way of fixing this would be to make the state stored server-side but this would be a much more intrusive patch and bring us (possibly permanently) out of alignment with upstream. This will cause a loss of current state so users will have to reopen any files they had open but I was not sure if it was worth copying the old state into a new database. |
jsjoeio
suggested changes
Feb 18, 2022
There was a problem hiding this comment.
Another way of fixing this would be to make the state stored server-side but this would be a much more intrusive patch and bring us (possibly permanently) out of alignment with upstream.
Based on this information, I agree. We should choose the least intrusive patch. Thanks for noting this!
minor nit about code comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes collisions where VS Code is serving a workspace with the same
name but on a different machine and hosted on the same domain.
I have an e2e test for this on the code-server side.