chore: remove superfluous context.Canceled handling (#13140)

spikecurtis · web-flow · commit 2efb46a10e33 · 2024-05-06T14:33:16.000+04:00
Removes a check for `context.Canceled` inside the `handleManifest` routine.  This checking is handled in the `apiConnRoutineManager`, so checking inside the handler is redundant.
diff --git a/agent/agent.go b/agent/agent.go
@@ -903,9 +903,6 @@ func (a *agent) handleManifest(manifestOK chan<- struct{}) func(ctx context.Cont
 			Subsystems:        subsys,
 		}})
 		if err != nil {
-			if xerrors.Is(err, context.Canceled) {
-				return nil
-			}
 			return xerrors.Errorf("update workspace agent startup: %w", err)
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -903,9 +903,6 @@ func (a *agent) handleManifest(manifestOK chan<- struct{}) func(ctx context.Cont`
`903`	`903`	`Subsystems: subsys,`
`904`	`904`	`}})`
`905`	`905`	`if err != nil {`
`906`		`- if xerrors.Is(err, context.Canceled) {`
`907`		`- return nil`
`908`		`- }`
`909`	`906`	`return xerrors.Errorf("update workspace agent startup: %w", err)`
`910`	`907`	`}`
`911`	`908`