fix: Rename coder to sshd on Windows for VS Code Remote support (#974)

kylecarbs · web-flow · commit db9d5b7e8c9d · 2022-04-11T21:14:30.000-05:00
On Windows, VS Code Remote requires a parent process of the executing shell to be named sshd, otherwise it fails. See: microsoft/vscode-remote-release#5699
diff --git a/provisionersdk/agent.go b/provisionersdk/agent.go
@@ -7,13 +7,16 @@ var (
 	// to agent install and run script. ${DOWNLOAD_URL} is replaced
 	// with strings.ReplaceAll() when being consumed.
 	agentScripts = map[string]map[string]string{
+		// On Windows, VS Code Remote requires a parent process of the
+		// executing shell to be named "sshd", otherwise it fails. See:
+		// https://github.com/microsoft/vscode-remote-release/issues/5699
 		"windows": {
 			"amd64": `
 $ProgressPreference = "SilentlyContinue"
-Invoke-WebRequest -Uri ${ACCESS_URL}bin/coder-windows-amd64.exe -OutFile $env:TEMP\coder.exe
+Invoke-WebRequest -Uri ${ACCESS_URL}bin/coder-windows-amd64.exe -OutFile $env:TEMP\sshd.exe
 $env:CODER_AUTH = "${AUTH_TYPE}"
 $env:CODER_URL = "${ACCESS_URL}"
-Start-Process -FilePath $env:TEMP\coder.exe -ArgumentList "workspaces","agent" -PassThru
+Start-Process -FilePath $env:TEMP\sshd.exe -ArgumentList "workspaces","agent" -PassThru
 `,
 		},
 		"linux": {
