You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of the ongoing theming effort, we should move away from MUI's styling machinery, and move towards consolidating on Emotion and the css prop as our de-facto form of styling.
A large amount of work has already gone towards this, by getting rid of all of our usage of makeStyles, but there's still more to do!
Convert all usage of the <Box> component to regular <div>s (or whichever if the component prop is used) using the css prop instead of sx. (189 uses)
Convert all other usage of the sx prop to the css prop (243 uses total, most of which will be <Box>)
Convert components made by withStyles and styled into thin wrapper components using a css prop (14 uses total)
Get rid of usage of theme.typography stuff (32 uses)
The main pitfall to watch out for in this work is that some number values provided to MUI/sx like margin, padding, and gap get multiplied by 8, while others like fontSize are preserved 🙃
The text was updated successfully, but these errors were encountered:
The current plan is for @BrunoQuaresma to handle withStyles, styled, and theme.typography, while I get started on <Box> and sx. Bruno will very likely finish first, and then we'll coordinate on splitting up the remaining bits.
Uh oh!
There was an error while loading. Please reload this page.
As part of the ongoing theming effort, we should move away from MUI's styling machinery, and move towards consolidating on Emotion and the
css
prop as our de-facto form of styling.A large amount of work has already gone towards this, by getting rid of all of our usage of
makeStyles
, but there's still more to do!Convert all usage of the
<Box>
component to regular<div>
s (or whichever if thecomponent
prop is used) using thecss
prop instead ofsx
. (189 uses)Convert all other usage of the
sx
prop to thecss
prop (243 uses total, most of which will be<Box>
)Convert components made by
withStyles
andstyled
into thin wrapper components using acss
prop (14 uses total)Get rid of usage of
theme.typography
stuff (32 uses)The main pitfall to watch out for in this work is that some number values provided to MUI/
sx
likemargin
,padding
, andgap
get multiplied by 8, while others likefontSize
are preserved 🙃The text was updated successfully, but these errors were encountered: