Skip to content

chore: de-MUI-fication week #10612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 4 tasks
aslilac opened this issue Nov 9, 2023 · 2 comments
Closed
3 of 4 tasks

chore: de-MUI-fication week #10612

aslilac opened this issue Nov 9, 2023 · 2 comments
Assignees

Comments

@aslilac
Copy link
Member

aslilac commented Nov 9, 2023

As part of the ongoing theming effort, we should move away from MUI's styling machinery, and move towards consolidating on Emotion and the css prop as our de-facto form of styling.

A large amount of work has already gone towards this, by getting rid of all of our usage of makeStyles, but there's still more to do!

  • Convert all usage of the <Box> component to regular <div>s (or whichever if the component prop is used) using the css prop instead of sx. (189 uses)

  • Convert all other usage of the sx prop to the css prop (243 uses total, most of which will be <Box>)

  • Convert components made by withStyles and styled into thin wrapper components using a css prop (14 uses total)

  • Get rid of usage of theme.typography stuff (32 uses)

The main pitfall to watch out for in this work is that some number values provided to MUI/sx like margin, padding, and gap get multiplied by 8, while others like fontSize are preserved 🙃

@aslilac
Copy link
Member Author

aslilac commented Nov 9, 2023

The current plan is for @BrunoQuaresma to handle withStyles, styled, and theme.typography, while I get started on <Box> and sx. Bruno will very likely finish first, and then we'll coordinate on splitting up the remaining bits.

@aslilac
Copy link
Member Author

aslilac commented Dec 4, 2023

we're gonna punt on theme.typography for now, so we'll close this since everything else is done!

@aslilac aslilac closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants