-
Notifications
You must be signed in to change notification settings - Fork 886
Coder "app" connections are not recorded as workspace usage for the purposes of detecting idle state #11812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@JoshVee On which version of Coder are you seeing this behaviour? |
Put in the next sprint:
|
I believe this should have been fixed by d583aca, which was included in 2.7.0 and later releases. Can anyone confirm if they are still seeing this behaviour? |
Autostop is determined by the deadline of the workspace build so if we're just updating |
Given that you can override the agent stats reporting interval, I wonder if setting this to a sufficiently high value could cause this behaviour? |
The apps do not report metrics via the agent stats. So the agent stats reporting interval does not change this behavior. |
My draft PR does fix this, but we should implement a batch sql query to handle this. The looping feels like it could be a performance hit. EDIT: @johnstcn mentioned the connection count on the agent. See I think this is resolved already. |
I am closing out this issue for now as "cannot reproduce". Please do not hesitate to re-open it if you have more information! In any case, we ensure this issue does not resurface when revamping activity detection (see: #12965) |
We are currently using code-server as a web app, via the
coder_app
resource.It appears as though connections through this endpoint do not get recorded as workspace usage, therefore the auto-stop behaviour can still occur while in use.
The text was updated successfully, but these errors were encountered: