Skip to content

shared ports: cleanup shared ports on template max share level change #12236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
f0ssel opened this issue Feb 20, 2024 · 4 comments · Fixed by #12411
Closed

shared ports: cleanup shared ports on template max share level change #12236

f0ssel opened this issue Feb 20, 2024 · 4 comments · Fixed by #12411
Assignees

Comments

@f0ssel
Copy link
Contributor

f0ssel commented Feb 20, 2024

No description provided.

@f0ssel f0ssel self-assigned this Feb 20, 2024
@cdr-bot cdr-bot bot added the bug label Feb 20, 2024
@stirby
Copy link
Collaborator

stirby commented Feb 27, 2024

I did notice the following behavior:

  • Max template sharing level is public
  • Have process on port 3000 on workspace X
  • share port as public
  • reduce max sharing level in template
  • the dropdown UI is updated, but the port is still shared as public

I assume issue seeks to address strict enforcement of the template sharing level?

@f0ssel
Copy link
Contributor Author

f0ssel commented Mar 4, 2024

Exactly, any shared ports based on that template that are above the new sharing level will be reduced down to the new level. This ensures that revoking access at the template level immediately goes into effect for all workspaces based on it.

@f0ssel
Copy link
Contributor Author

f0ssel commented Mar 4, 2024

This also means that when the level is reduced to owner that all the shared ports will be deleted. I think this is better than trying to show some representation of a "public" shared port that is disabled because of the template level - just seemed too complicated to explain to the user IMO.

@stirby
Copy link
Collaborator

stirby commented Mar 5, 2024

Sounds great - Totally agree on deleting the shared ports when an admin reduces the max level to owner.

Can we add a note or disclaimer that when the admin reduces it? Something as simple as "Reducing max share level to owner will remove shared ports on workspaces using this template."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants