Skip to content

No restart confirmation when changing workspace parameters #14319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stirby opened this issue Aug 15, 2024 · 3 comments
Open

No restart confirmation when changing workspace parameters #14319

stirby opened this issue Aug 15, 2024 · 3 comments
Labels
customer-requested Features requested by enterprise customers. Only humans may set this. design needed Request for more beauty enterprise Enterprise-license / premium functionality site Area: frontend dashboard

Comments

@stirby
Copy link
Collaborator

stirby commented Aug 15, 2024

Problem

When changing workspace parameters in the UI (workspaces -> settings -> parameters), the submit button immediately triggers a workspace restart. This is annoying for customers as we don't display a warning against losing data when the workspace is running.

workspace_parameter_immediate_restart

Proposal

When restarting a workspace elsewhere in the UI, we have a large confirmation window to prevent work loss. We should add this as a second step when the user presses "submit" on the workspace parameters page when the workspace is running.

Screenshot 2024-08-15 at 2 09 22 PM

Stretch idea

We could give users the option to wait until the next restart with an adjusted dialogue. This will allow them one of two options:

  • Apply the parameter changes now
  • Apply the changes upon next restart

I am unsure if this is feasible as we'd have to store the new parameter values, and show that they're outdated in UI until the workspace restarts.

Screenshot 2024-08-15 at 4 17 37 PM

@stirby
Copy link
Collaborator Author

stirby commented Sep 24, 2024

This is also a headache when changing any workspace settings; the same changes should be applied.

@stirby stirby added the customer-requested Features requested by enterprise customers. Only humans may set this. label Sep 24, 2024
@stirby
Copy link
Collaborator Author

stirby commented Sep 24, 2024

Slotting this into the next sprint as it's come up a lot with our customers recently.

@stirby
Copy link
Collaborator Author

stirby commented Sep 26, 2024

In the dialogue box, we should include a checkbox to update the workspace upon the immediate restart or ignore the update. Not all workspaces require an update when restarting depending on template update policies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-requested Features requested by enterprise customers. Only humans may set this. design needed Request for more beauty enterprise Enterprise-license / premium functionality site Area: frontend dashboard
Projects
None yet
Development

No branches or pull requests

2 participants