Skip to content

Mark parameter autofill experiment as safe #14458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stirby opened this issue Aug 27, 2024 · 2 comments
Open

Mark parameter autofill experiment as safe #14458

stirby opened this issue Aug 27, 2024 · 2 comments
Assignees
@stirby
Labels
release/experimental These changes are feature-flagged, they may change or be removed in future releases

Comments

@stirby
Copy link
Collaborator

stirby commented Aug 27, 2024

The auto-fill-parameters feature was moved behind an experiment but not added to the list of safe experiments. A customer recently came to us asking to bring the feature back.

It's not a breaking, dangerous, or incomplete feature -- It just wasn't demanded unanimously. We should mark it as safe.

We need to add it here. Tracking this as an issue for triage.
@stirby stirby added chore release/experimental These changes are feature-flagged, they may change or be removed in future releases labels Aug 27, 2024
@stirby stirby self-assigned this Aug 27, 2024
@ammario
Copy link
Member

ammario commented Sep 20, 2024

The issue that led to its revert was that template admins want users to set some parameters from scratch each time. I imagine a disk size parameter as a good example of that. Users don't really care if they use a lot of disk so template admins want them to affirmatively request it each time. If someone has more examples it would be good to hear them.

It would be nice to release this feature properly in some way that's not an obscure feature flag so users can actually benefit from it. I understand @code-asher is investigating the parameter system holistically, perhaps this is a good place to start.

@ammario ammario mentioned this issue Sep 20, 2024
Closed
@ammario
Copy link
Member

ammario commented Sep 20, 2024

actually I think we should do this #14757

@matifali matifali removed the chore label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stirby stirby

Labels
release/experimental These changes are feature-flagged, they may change or be removed in future releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ammario @matifali @stirby