Skip to content

Bug: FE presents undetailed error message for username validation #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
greyscaled opened this issue May 23, 2022 · 2 comments · Fixed by #1851
Closed

Bug: FE presents undetailed error message for username validation #1693

greyscaled opened this issue May 23, 2022 · 2 comments · Fixed by #1851
Assignees
@oxy
Labels
site Area: frontend dashboard
Milestone
Community MVP

Comments

@greyscaled
Copy link
Contributor

greyscaled commented May 23, 2022 •
edited
Loading

This is a spawn-off of #1689 (thanks @oxy 🎉)

Steps to Reproduce

See #1689

Expected

A helpful error message regarding what letters/characters/combinations the username accepts

Actual

An undetailed error message

Screenshot

169904635-8063880a-6d28-45b1-836c-cce8ce82bc48

Notes

The Yup validation needs improvements here:

coder/site/src/components/SettingsAccountForm/SettingsAccountForm.tsx

Line 25 in c465f8a

username: Yup.string().trim(),

This uses username validation, which is a custom validator we have in our backend.

To source this, see that the struct has a username tag here:

coder/codersdk/users.go

Line 57 in c465f8a

Username string `json:"username" validate:"required,username"`

Which is defined here:

coder/coderd/httpapi/httpapi.go

Lines 34 to 47 in c465f8a

err := validate.RegisterValidation("username", func(fl validator.FieldLevel) bool {
f := fl.Field().Interface()
str, ok := f.(string)
if !ok {
return false
}
if len(str) > 32 {
return false
}
if len(str) < 1 {
return false
}
return usernameRegex.MatchString(str)
})

coder/coderd/httpapi/httpapi.go

Line 18 in c465f8a

usernameRegex = regexp.MustCompile("^[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*$")

@greyscaled greyscaled added bug 🐛 site Area: frontend dashboard labels May 23, 2022
@greyscaled
Copy link
Contributor Author

Please add your planning poker estimate with ZenHub @Kira-Pilot

@greyscaled
Copy link
Contributor Author

Further note:

The implementation to this FE is identical to #1453 but applied to a user's username with different product copy

@misskniss misskniss added this to the Community MVP milestone May 24, 2022
@oxy oxy mentioned this issue May 27, 2022
Merged
4 tasks
@oxy oxy closed this as completed in #1851 May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxy oxy

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

fix(site): username validation in forms coder/coder
3 participants
@misskniss @greyscaled @oxy