Skip to content

bug: keep go versions in sync #17063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
spikecurtis opened this issue Mar 24, 2025 · 0 comments · Fixed by #17149
Closed
1 task done

bug: keep go versions in sync #17063

spikecurtis opened this issue Mar 24, 2025 · 0 comments · Fixed by #17149
Assignees
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Comments

@spikecurtis
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

We define the Go version in multiple places, at least the following:

  • dogfood/coder/Dockerfile
  • flake.nix
  • go.mod
  • .github/actions/setup-go/action.yaml

And, we keep updating some but not all of them at once. We need some way to keep them in sync.

Ideally, we'd have some single source of truth for the Go version in the repo. If that's impractical, some sort of CI check to ensure they are all in sync.

Relevant Log Output

Expected Behavior

No response

Steps to Reproduce

Look at the files and see they don't use the same version.

Environment

  • Host OS:
  • Coder version:

Additional Context

No response

@spikecurtis spikecurtis added needs-triage Issue that require triage s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks and removed needs-triage Issue that require triage labels Mar 24, 2025
@johnstcn johnstcn self-assigned this Mar 28, 2025
EdwardAngert pushed a commit that referenced this issue Apr 1, 2025
Fixes #17063

I'm ignoring flake.nix for now.

```
$ IGNORE_NIX=true ./scripts/check_go_versions.sh
INFO : go.mod                   : 1.24.1
INFO : dogfood/coder/Dockerfile : 1.24.1
INFO : setup-go/action.yaml     : 1.24.1
INFO : flake.nix                : 1.22
INFO : Ignoring flake.nix, as IGNORE_NIX=true
Go version check passed, all versions are 1.24.1

$ ./scripts/check_go_versions.sh
INFO : go.mod                   : 1.24.1
INFO : dogfood/coder/Dockerfile : 1.24.1
INFO : setup-go/action.yaml     : 1.24.1
INFO : flake.nix                : 1.22
ERROR: Go version mismatch between go.mod and flake.nix
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants