Skip to content

Separate active jobs from completed jobs #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ketang opened this issue Jun 5, 2022 · 11 comments
Closed

Separate active jobs from completed jobs #2065

ketang opened this issue Jun 5, 2022 · 11 comments
Labels
site Area: frontend dashboard stale This issue is like stale bread.

Comments

@ketang
Copy link
Contributor

ketang commented Jun 5, 2022

What is your suggestion?

Separate the Timeline (which should be "History" #2064) into two parts: active jobs and completed/terminated jobs. Basically duplicate the current table, limit one to actively running jobs and move it above Resources and omit actively running jobs from the other but leave it otherwise unchanged. Name the first one something like "Actions in progress" or "Pending actions;" there are a half dozen options that work.

Often this section will be empty and just have a header. This is a feature and good.

An elaboration that would make this better would be to change some of the columns. "Pending actions" doesn't need a status, for instance, while it would benefit from an actively updated duration (right now it just shows "In progress" until it's done). "Status" in the History is more general; "Result" would be more appropriate to something that will either be "Succeeded," "Failed," or "Unknown."

Why do you want this feature?

The timeline commingles past and present in a way that can be confusing even ignoring the issue with "Running" (#1677).

Are there any workarounds to get this functionality today?

n/a

Are you interested in submitting a PR for this?

no

@kylecarbs
Copy link
Member

I think this will make the UI confusing. If we fix #1677 I don't believe this will be a problem.

A workspace can only have a single running job, so I'm not sure what the other view would even display.

@ketang
Copy link
Contributor Author

ketang commented Jun 5, 2022

Why can it only have one running job? I'm not sure that's a good thing forever, for instance a workspace that has a Windows VM and a Linux VM in it. You'd want to do that in parallel if possible.

Having only one running job doesn't weaken the advantage. It makes it easy to distinguish between "something is happening" and "nothing is happening." It's helpful to be able to see that at a glance.

@kylecarbs
Copy link
Member

It's on our provisioners in our current model to provision in parallel.

I'm not opposed to the second argument. I'd like to see a mock before we make this happen.

@ketang
Copy link
Contributor Author

ketang commented Jun 6, 2022

I'd like to avoid baking in serial provisioning for a single workspace. Componentizing templates to be parallelizable will be an adventure, but it's an inevitable one.

@kylecarbs
Copy link
Member

@tjcran we shouldn't do this for Community. There are many many many unknowns in regards to this ATM.

@ketang
Copy link
Contributor Author

ketang commented Jun 6, 2022

Yeah, even if those were all resolved, this can wait.

@ketang
Copy link
Contributor Author

ketang commented Jun 6, 2022

You have no idea what I had to do to create these mocks.

With an active job:
coder-workspace-active-jobs-mock

With no active jobs:
coder-workspace-no-active-jobs-mock

In retrospect the text should say "No active jobs" instead of "Active jobs."

Eventually we'll have a count.

@kylecarbs kylecarbs changed the title Feat: separate active jobs from completed jobs Separate active jobs from completed jobs Jun 7, 2022
@tjcran
Copy link

tjcran commented Jun 7, 2022

@ketang is this not a duplicate of #2022 ?

@ketang
Copy link
Contributor Author

ketang commented Jun 8, 2022

Almost but not quite. Maybe it's close enough.

@misskniss misskniss added the site Area: frontend dashboard label Jun 14, 2022
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Aug 16, 2022
@tjcran
Copy link

tjcran commented Aug 16, 2022

Closing this as not planned.

@tjcran tjcran closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard stale This issue is like stale bread.
Projects
None yet
Development

No branches or pull requests

4 participants