Skip to content

General pagination #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
Tracked by #4748
ammario opened this issue Sep 6, 2022 · 4 comments
Closed
8 tasks done
Tracked by #4748

General pagination #3907

ammario opened this issue Sep 6, 2022 · 4 comments
Assignees
Milestone

Comments

@ammario
Copy link
Member

ammario commented Sep 6, 2022

We want to support deployments with hundreds of users by the end of the year. Many of our current views do not support this kind of scale.

We can leave the Templates page as is. We assume the number of templates will grow logarithmically with the number of users.

In the future we may want to paginate:

  • Groups page
    • users within groups
  • Build log
    But they're not a priority now.

We'll follow the pattern of pagination used in the Audit Log - limit/offset style pagination, with controls allowing the user to go forward, back, or to a specific page.

We will not apply pagination to the CLI because losing an entry due to the limit/offset style could be problematic there.

Each page needs both the item fetching to be paginated and a count endpoint. They're separate endpoints so that the count one can be called less frequently, as it's more expensive.

@ammario ammario added the feature label Sep 6, 2022
@ammario ammario added this to the EE milestone Sep 7, 2022
@BrunoQuaresma
Copy link
Collaborator

I like this, but I would wait until we have a customer requesting that.

@ammario ammario changed the title Paginate Workspaces page General pagination Oct 5, 2022
@bpmct
Copy link
Member

bpmct commented Oct 8, 2022

We've seen a few requests for this - this is particularly painful for workspaces that have been alive for over 30 days since the build log gets quite long

@ammario
Copy link
Member Author

ammario commented Oct 9, 2022

We've seen a few requests for this - this is particularly painful for workspaces that have been alive for over 30 days since the build log gets quite long

#4436 fixes this case specifically.

@bpmct
Copy link
Member

bpmct commented Nov 7, 2022

Let's hold off on doing other pages besides Users and Workspaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants