-
Notifications
You must be signed in to change notification settings - Fork 881
bug: allow ignoring OIDC email_verified claim #5065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
i set CODER_OIDC_IGNORE_EMAIL_VERIFIED as true, but it still shows the same error |
@johnstcn is this going to be a breaking change for us as this gets implemented. We're relying on that bypass that @kylecarbs implemented at the moment so people can get in using AzureAD integration. I.e. Should I be setting not yet implemented |
In your use-case, the Does that sound reasonable to you? |
@johnstcn ah yes sorry I was having a moment. You're right it wasn't coming through at all that was our issue. |
@wanghongda-0624 It hasn't been implemented yet :-) Working on it! |
Problem
(Context: see #3954)
Coder will check for the
email_verified
OIDC claim if it is provided, and block sign-in if the user's email is not verified.Users with unverified emails atttempting to login will get a message similar to
From the Auth0 docs:
https://auth0.com/docs/manage-users/user-accounts/user-profiles/verified-email-usage
This means that certain IdPs through Auth0 (for example, AzureAD) are essentially unusable with Coder currently -- if the IdP does not return the
email_verified
claim, Auth0 will default it tofalse
and Coder will block sign-in.Solution
Add a command-line flag / environment variable
CODER_OIDC_IGNORE_EMAIL_VERIFIED
.This will default to false. If it is set to true, skip the code path to check the
email_verified
claim:https://github.com/coder/coder/blob/4b3d211e004ec5e4a3b30f98ca3c3e8ec687168a/coderd/userauth.go#L251-260
This will essentially assume that all emails are verified.
The text was updated successfully, but these errors were encountered: