Skip to content

feat: add CODER_OIDC_IGNORE_EMAIL_VERIFIED config knob #5165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 25, 2022
Merged

feat: add CODER_OIDC_IGNORE_EMAIL_VERIFIED config knob #5165

merged 8 commits into from
Nov 25, 2022

Conversation

johnstcn
Copy link
Member

Fixes #5065

@johnstcn johnstcn self-assigned this Nov 24, 2022
@github-actions
Copy link

github-actions bot commented Nov 24, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@johnstcn johnstcn marked this pull request as ready for review November 24, 2022 09:13
@johnstcn
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

@johnstcn
Copy link
Member Author

recheck

mtojek
mtojek approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some nit-picks

cli/deployment/config_test.go Outdated
require.Equal(t, config.OIDC.Scopes.Value, []string{"something", "here"})
require.Equal(t, config.OIDC.IgnoreEmailVerified.Value, true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: require.True

mafredri
mafredri approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@johnstcn johnstcn requested a review from a team as a code owner November 24, 2022 10:08
@johnstcn johnstcn requested review from Kira-Pilot and removed request for a team November 24, 2022 10:08
@johnstcn johnstcn merged commit a4a319a into main Nov 25, 2022
@johnstcn johnstcn deleted the cj/oidc-ignore-email-verified branch November 25, 2022 10:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@mtojek mtojek mtojek approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

@Kira-Pilot Kira-Pilot Awaiting requested review from Kira-Pilot Kira-Pilot was automatically assigned from coder/ts

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: allow ignoring OIDC email_verified claim
3 participants
@johnstcn @mafredri @mtojek