Skip to content

rich parameters: import values from legacy parameters #6368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtojek opened this issue Feb 28, 2023 · 5 comments · Fixed by #6556
Closed

rich parameters: import values from legacy parameters #6368

mtojek opened this issue Feb 28, 2023 · 5 comments · Fixed by #6556
Assignees
@mtojek
Labels
parameters Area: parameters
Milestone
Rich Parameters GA

Comments

@mtojek
Copy link
Member

mtojek commented Feb 28, 2023

The idea here is to import values from legacy parameters to make the migration smoother. coder_parameters should use the matching value of a legacy parameter before switching to default.

@kylecarbs has an idea to introduce legacy_variable_name or legacy_name to mark the legacy name.
@mtojek mtojek added the parameters Area: parameters label Feb 28, 2023
@bpmct bpmct added this to the Rich Parameters GA milestone Feb 28, 2023
@mtojek mtojek self-assigned this Mar 7, 2023
@mtojek mtojek mentioned this issue Mar 7, 2023
Merged
@mtojek
Copy link
Member Author

mtojek commented Mar 7, 2023

Hey @bpmct! The legacy_variable should be present in the v0.6.16 release of terraform-provider-coder (baking now). I think that you can try to migrate some old template (if you have a candidate) 👍

@mtojek mtojek closed this as completed Mar 9, 2023
@mtojek
Copy link
Member Author

mtojek commented Mar 9, 2023

Reopening as I found this buggy, need more time to spend on this

@mtojek mtojek reopened this Mar 9, 2023
@mtojek
Copy link
Member Author

mtojek commented Mar 9, 2023 •
edited
Loading

Related: coder/terraform-provider-coder#109 (review)

Ok, I've done more research. Unfortunately, this PR is insufficient, and we also need to sneak the legacy_parameter_name property for migration purposes.

The legacy_variable property works well with targetting the default value, but if only we need to switch from the old parameter to coder_parameter (strip reference to a legacy variable), the coder_parameter loses context, and takes the default. This is due to the fact that we pass all build parameter values externally, and there is no mechanism/logic to pull the legacy variable value.

@mtojek mtojek mentioned this issue Mar 9, 2023
Closed
@mtojek
Copy link
Member Author

mtojek commented Mar 9, 2023

cc @kylecarbs if you have any alternative idea how to approach this problem ^

@kylecarbs
Copy link
Member

No additional thoughts, the above makes sense. I think it's fine to have the legacy_parameter_name property in for now, it makes a lot of sense for users.

This was referenced Mar 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
parameters Area: parameters
Projects
None yet
Milestone
Rich Parameters GA
Development

Successfully merging a pull request may close this issue.

feat: import value from legacy variable to build parameter mtojek/coder
3 participants
@kylecarbs @mtojek @bpmct