Skip to content

Please put a stop button on failed workspaces #6468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcarrion87 opened this issue Mar 6, 2023 · 5 comments · Fixed by #6622
Closed

Please put a stop button on failed workspaces #6468

dcarrion87 opened this issue Mar 6, 2023 · 5 comments · Fixed by #6622
Assignees
Labels
site Area: frontend dashboard

Comments

@dcarrion87
Copy link
Contributor

dcarrion87 commented Mar 6, 2023

Failing Coder auto cleaning up failed workspaces after a certain time can you put a stop button for users to click when their workspace fails so they can clean up failed resources without having to delete the workspace. There is something about the "delete" button that users are inherently allergic to and we find ourselves having to clean up for them. We are trying to avoid tech debt writing custom code outside coder to do things like auto clean up failed workspaces.

People leaving failed or even stopped workspaces around forever is a pain point and we have enough tech debt around coder at the moment and don't want to extend it to a cleanup that I feel Coder could just have as a feature.

As you know we work with limited compute so it's often that users try to allocate and fail due to lack of available resources. But there are other reasons why they stop and fail as well. We log events to Cloudwatch so we can check later.

@dcarrion87
Copy link
Contributor Author

Frustrating: #5815 (comment)

@BrunoQuaresma BrunoQuaresma added the site Area: frontend dashboard label Mar 8, 2023
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 8, 2023
@BrunoQuaresma
Copy link
Collaborator

If the workspace is "failed" I would assume it is not started right? If is not started the user can't "stop" it. Am I missing something?

@kylecarbs
Copy link
Member

@BrunoQuaresma a workspace is idempotent and can enter any state from failed. Failed can mean it failed to start, or failed to stop. It should probably show start or stop if we're in the failed state.

@BrunoQuaresma
Copy link
Collaborator

@kylecarbs when it is failed, how do we know the current status? Asking because the status right now can be "stopped" or "failed".

export type WorkspaceStatus =
| "canceled"
| "canceling"
| "deleted"
| "deleting"
| "failed"
| "pending"
| "running"
| "starting"
| "stopped"
| "stopping"

@kylecarbs
Copy link
Member

We don't need to know how it got into a failed state, because failed is its own state that can be directed into stop or start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants