Skip to content

Add unit tests for Helm chart #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Mar 10, 2023 · 0 comments · Fixed by #6557
Closed

Add unit tests for Helm chart #6552

johnstcn opened this issue Mar 10, 2023 · 0 comments · Fixed by #6557
Assignees
@johnstcn

Comments

@johnstcn
Copy link
Member

This would prevent issues like #6544 and give us greater confidence in shipping changes to our v2 Helm chart.

We can probably fork-lift most of the test framework from enterprise-helm
@johnstcn johnstcn self-assigned this Mar 10, 2023
@johnstcn johnstcn mentioned this issue Mar 10, 2023
Merged
johnstcn added a commit that referenced this issue Mar 13, 2023
@johnstcn
chore(helm): add unit tests for helm chart (#6557)
9b2abf0 
This PR adds a minimum set of Helm tests for the Helm chart.
It's heavily based on the approach in [1], but uses a golden-files-based approach instead.
It also runs helm template directly instead of importing the entire Kubernetes API.
Golden files can be updated by running go test ./helm/tests -update or by running make update-golden-files.

[1] https://github.com/coder/enterprise-helm

Fixes #6552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(helm): add unit tests for helm chart coder/coder
1 participant
@johnstcn