-
Notifications
You must be signed in to change notification settings - Fork 887
groups: auto-create all groups sent from OIDC groups claim #8214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
One thing that might be helpful here is to add The group naming scheme from this particular customer is sometimes a bit cryptic as they are auto generated. |
I would like to have a discussion on how to achieve this. My concerns:
|
One thing we should do is a "Identifier Name" vs "Display/Friendly Name". The ID name must accept more characters and probably needs to be url escaped. |
No, I don't think this is necessary.
We could provide a basic bash script in the docs to do this with curl + jq. Query all group IDs that were created after a certain time and a second script to delete.
On our call, we discussed doing it in the product. Since some customers may have less control over their OIDC claims. What are your thoughts on making this opt-in via a flag @Emyrk? It would suck if a bunch of groups to appear in a Coder deployment as a breaking change.
One thing we discussed was that once imported, a group cannot be deleted from Coder. I think we should actually support this. When a user logs in again, the group can be re-created if the claim sent it. However, editing assignments should be disabled #6549 |
an enterprise customer recently configured group sync with AD. they have 1000s of groups. currently, to configure group sync for a group of users in Coder, they have to:
OIDC_GROUP_MAPPING
env var & update Coderthis process is sufficient for a small POC, but they provided feedback that this will be cumbersome for tens to hundreds of groups expected to sync with Coder. they suggested the default group name be group ID passed in from the IdP (they'd update the name as a later step). this would also allow a one-time setting of the
OIDC_GROUP_MAPPING
var to the pre-defined IDs > group names.The text was updated successfully, but these errors were encountered: