-
Notifications
You must be signed in to change notification settings - Fork 886
Document predefined emoji/icon images #8344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Not sure if I got it 🤔 do you have any mocks? |
Ah sorry! Several elements in Coder templates require an icon URL which is often an emoji in our |
I think it'd be a bit nice to integrate this into the UI, rather than telling users "go find one over here and then come back" Looks like the picker component we use supports custom emojis/images/icons/whatever as well |
@bpmct can you think of any other places in the app where we should be showing a "picker" for this sort of thing but don't currently? |
I think this is more for when users are setting emojis and icons on TF configuration |
ah ok, that makes sense |
Yeah agreed so I think it is fine as a detached page since most people will go to it from code comments. Cool that it supports icons too! Another idea is to show this on our docs or coder.com but then it may drift across versions and not work for our enterprise customers offline networks |
I've seen some stuff in the code base around offline docs but I don't exactly have all the context there. We could also just do both, especially if we could generate them from the same source of truth to prevent drift. Meet people where they're at, make things like this as discoverable as we can. |
I especially like that they have some language icons in there (Rust, Go, TS). I think we could benefit from those as well, so that you could have multiple Docker templates with better icons. |
Agreed! |
@aslilac, is it at Also, let us keep this open until we document how to use this. |
which is why it can't be /icon. that would be a routing conflict. plus it just sounds weird. |
Or we can just rename it to /icons and mark as a breaking change. As it will need app users to update their templates. |
that would also be a routing conflict. 😅 |
what places exactly do we need to document this to close the issue? |
TBH, it's not very clear at the moment. Maybe someplace in https://coder.com/docs/v2/latest/templates or we can wait for this significant refactoring to merge, |
When adding a workspace proxy, setting an icon for Coder app, etc you can set an icon URL. Right now, power users know to go to the template settings page to see the icon picker and get the right URL.
Can we add a
https://coder.example.com/icons
which just has the icon picker component so they can easily get an icon URL? It would also be nice if it statically rendered the paths for stuff like VS Code, JetBrains, and other icons we statically host. Then, in thewsproxy create
help text and UI (and in the terraform provider docs) we can tell people to navigate there to see available icons.The text was updated successfully, but these errors were encountered: