Skip to content

All Terminals Disconnect On Single Close #8772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ElioDiNino opened this issue Jul 27, 2023 · 7 comments · Fixed by #8917
Closed

All Terminals Disconnect On Single Close #8772

ElioDiNino opened this issue Jul 27, 2023 · 7 comments · Fixed by #8917
Assignees
Labels
s1 Bugs that break core workflows. Only humans may set this.

Comments

@ElioDiNino
Copy link
Contributor

Version: v0.27.1+65583ec

Problems

  1. When you have multiple terminals open for a given workspace (and/or coder_apps that run a command) and you close one of them, they all show the disconnected screen (photos below)
  2. The disconnect screen says "Press any key to retry" but the only valid keys (at least on macOS) seem to be control, option, command, space bar, and shift.

Example

Various terminals open
Screenshot 2023-07-27 at 9 18 01 AM

After closing one terminal
Screenshot 2023-07-27 at 9 21 59 AM

@cdr-bot cdr-bot bot added the bug label Jul 27, 2023
@kylecarbs
Copy link
Member

Oof, this is a weird bug. We'll definitely fix it.

@spettinichi
Copy link

spettinichi commented Aug 1, 2023

Came here to mention the "any key" confuses people, we had to start telling people to hit space, so thank you for identifying more keys which work! We are also mostly on Mac, so unsure about other OSes but I will see if I can gather more information.
This also explains some weirdness we've seen with terminals timing out seemingly too quickly.

@spettinichi
Copy link

Spoke with someone else and same issues on Windows. The working keys seem to be space, shift, alt, ctrl, and the windows key.

@matifali
Copy link
Member

matifali commented Aug 2, 2023

@spettinichi you are right I can reproduce it on Windows. Part 2 of the OP is a duplicate of #8547

@matifali matifali added the s2 Broken use cases or features (with a workaround). Only humans may set this. label Aug 2, 2023
@spettinichi
Copy link

Ahh thanks for linking that! I didn't realize there was already a separate ticket for Windows!

@kconley-sq
Copy link
Contributor

I encountered into this issue too on v0.27.3 and noticed that in addition to affecting other web terminals, if you close a web terminal while having some other workspace application open then it also seems to interfere with that application.

For example, the window for Android Studio via JetBrains Projector shows the following for a few seconds after you close a web terminal window:

image

After a few seconds, the workspace application stops showing that connection message and goes back to normal.

@bpmct bpmct added s1 Bugs that break core workflows. Only humans may set this. and removed s2 Broken use cases or features (with a workaround). Only humans may set this. labels Aug 3, 2023
@bpmct
Copy link
Member

bpmct commented Aug 4, 2023

We're able to reproduce this consistently on some of our clients and are investigating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s1 Bugs that break core workflows. Only humans may set this.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants