-
Notifications
You must be signed in to change notification settings - Fork 884
Resource metadata item value truncated despite ample space in workspace dashboard table #8887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc: @BrunoQuaresma |
More context about this, since we don't control what kind of information the user can add to it, it is hard to control and guess what is the best width so we are setting it statically using a fixed width. We could also re-think the design of it if that is the case. |
@BrunoQuaresma what do you think about having a field resource "coder_metadata" "device" {
# other fields elided...
item {
key = "Test"
value = "The quick brown fox jumped over the lazy dog"
width = "50px"
}
} |
It looks hacky but at the same time an available option 🤔 I would like to have more opinions on this. |
I'm hoping template developers might not have to specify It looks like the Coder website UI has available space to show more of the string in this issue as well as the multiple metadata strings in #9457, so as a first step would it be possible to make the UI show as many metadata strings (and as much of those strings) as possible given the available space in the agent row on the dashboard? |
I spent a bunch of time trying to get something "elegant" working and came up quite short. |
That's actually kind of a different issue, and the fix I had in mind for this one will not fix that one. 😅 To be honest, I don't even know how possible fixing both of them together is, and I really hate fighting with grids and flexboxes. The desire to grow and shrink in the specific way that we would need is just...not realistic. I spent nearly a whole day butting my head against it and got nowhere. |
@aslilac can I assign this to me? I have an idea how to make that happen if that is ok for you 👀 |
yes please 😂 |
@BrunoQuaresma I'll let you reopen and reassign if you still wanna do further work on this! |
I understand the changes in #9832 to help with this issue only take effect if you only have one metadata item for a resource, but unfortunately I have two. 😅 Can we reopen this ticket to track fixing this issue independent of the number of metadata items used? |
cc @bpmct, can we reopen this issue? I can still reproduce the scenario described in the first comment on the issue (where two metadata items are used) in v2.4.0. |
@kconley-sq we are working on a new workspace page that is probably going to fix that. It is probably going to be available as an experiment around January. Does it work? |
Yes that sounds good, thank you @BrunoQuaresma! |
@kconley-sq would it be possible to share some resource metadata you have that might resolve this issue? I want to make sure we are working with real data and see what it looks like outside of the "perfect" simulated data. It does not need to have the values, but rather strings that can represent their length. |
@BrunoQuaresma sure, here is an example:
|
@kconley-sq I think this is solved on 2.7.0 but feel free to re-open it in case it is not 🙏 |
In Coder v0.27.3 we're seeing that the value of a resource metadata item is truncated with ellipsis even though there seems to be enough space to show more (or even all) of the value in the workspace dashboard table on the Coder website:
Can that be improved to show more (or all if possible) of the value?
The text was updated successfully, but these errors were encountered: