Skip to content

Chore: Dependabot PRs initially fail Chromatic (token access) #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
greyscaled opened this issue Apr 6, 2022 · 2 comments
Closed

Chore: Dependabot PRs initially fail Chromatic (token access) #907

greyscaled opened this issue Apr 6, 2022 · 2 comments
Assignees
@greyscaled
Labels
site Area: frontend dashboard
Milestone
V2 Beta

Comments

@greyscaled
Copy link
Contributor

greyscaled commented Apr 6, 2022 •
edited
Loading

Summary

When dependabot issues PRs to update dependencies, the Chromatic check will always initially fail until re-run by someone at Coder. This is because the token is not applied for that agent.

Steps to Reproduce

  1. Dependabot opens a PR
  2. Chromatic fails (no token)

Expected

  1. Dependabot opens a PR
  2. Chromatic runs as normal

Logs

See here: https://github.com/coder/coder/runs/5859401270?check_suite_focus=true#step:4:47

From this PR created by dependabot: #902

Notes

A simple stop-gap solution is to not run chromatic on dependabot updates; however this feels unfortunate, as we'd be losing visual regression prevention on dependency updates. Ideally there's some way to allow dependabot to access this secret.
@greyscaled greyscaled self-assigned this Apr 6, 2022
@greyscaled
Copy link
Contributor Author

#910 will fix this since we're exposing the token. The token is safe to expose (to get access to Chromatic still requires Git auth and being in the coder organization). The one downside to exposing the token is that any/all forks can run builds on our chromatic, which we are billed for.

We'll have to see what this entails as we open source and gain traction, though I imagine going with a Standard billing tier will suffice just well.

Again, we'll need to monitor.

@greyscaled greyscaled mentioned this issue Apr 7, 2022
Merged
@kylecarbs
Copy link
Member

This should be fixed! Thanks for linking the issue, and the additional context @vapurrmaid.

@misskniss misskniss added this to the V2 Beta milestone May 3, 2022
@misskniss misskniss added V2 BETA site Area: frontend dashboard labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greyscaled greyscaled

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
V2 Beta
Development

No branches or pull requests
3 participants
@misskniss @kylecarbs @greyscaled