chore: compute job status as column #10024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
Oct 3, 2023
Comment on lines
136
to
153
| WHEN @status = 'starting' THEN | ||
| latest_build.started_at IS NOT NULL AND | ||
| latest_build.canceled_at IS NULL AND | ||
| latest_build.completed_at IS NULL AND | ||
| latest_build.job_status = 'running' AND | ||
| -- TODO: Should we drop the interval? Hung workspaces | ||
| -- should still be their last state? | ||
| latest_build.updated_at - INTERVAL '30 seconds' < NOW() AND | ||
| latest_build.transition = 'start'::workspace_transition | ||
|
|
||
| WHEN @status = 'running' THEN | ||
| latest_build.completed_at IS NOT NULL AND | ||
| latest_build.canceled_at IS NULL AND | ||
| latest_build.error IS NULL AND | ||
| latest_build.transition = 'start'::workspace_transition | ||
|
|
||
| WHEN @status = 'stopping' THEN | ||
| latest_build.started_at IS NOT NULL AND | ||
| latest_build.canceled_at IS NULL AND | ||
| latest_build.completed_at IS NULL AND | ||
| latest_build.job_status = 'running' AND | ||
| -- TODO: Should we drop the interval? Hung workspaces | ||
| -- should still be their last state? | ||
| latest_build.updated_at - INTERVAL '30 seconds' < NOW() AND | ||
| latest_build.transition = 'stop'::workspace_transition | ||
| WHEN @status = 'deleting' THEN | ||
| latest_build.job_status = 'running' AND | ||
| -- TODO: Should we drop the interval? Hung workspaces | ||
| -- should still be their last state? | ||
| latest_build.updated_at - INTERVAL '30 seconds' < NOW() AND | ||
| latest_build.transition = 'delete'::workspace_transition |
There was a problem hiding this comment.
I think these intervals are to ignore "hung jobs", but it feels odd to include that in some of the statuses, and not others.
I am going to drop the intervals, and defer to somewhere else to detect "hung" state. Like the UI or something. The updated_at timestamp is returned to the caller to decide.
coadler
approved these changes
Oct 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
I am working on pruning some template_versions, and currently provisioner job status is computed in Go. This makes it hard to make status decisions in SQL if I wrote a
prunequery.We also duplicate this status logic in the
workspaces.sqlfile for search strings.To keep status on the job, I added a postgres computed column to keep the status logic in 1 place and attached to the job.