-
Notifications
You must be signed in to change notification settings - Fork 886
chore: add vault icon #10125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add vault icon #10125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
@aslilac I think some recent changes cause what we are doing regarding displaying icons. Can you please take a look? I think we need to update |
I already updated |
can we use the file from here instead: https://github.com/hashicorp/vault/blob/main/ui/public/vault-logo.svg issued under a known license, and we can just recolor it to their brand yellow |
Hashicorp has both black and yello icons for the vault. Yellow looks better our dark UI. I guess it will be fine on the light UI too once we do it. |
And I did run |
yeah but the one you used doesn't seem like it's from hashicorp, it contains some comment about another website I've never heard of. I'd rather not use one from an unknown source, we should use one we obtained from hashicorp. 😅 |
maybe try |
No description provided.