Skip to content

chore: add vault icon #10125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2023
Merged

chore: add vault icon #10125

merged 3 commits into from
Oct 9, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Oct 9, 2023

No description provided.

@matifali matifali added the hotfix label Oct 9, 2023
@matifali matifali self-assigned this Oct 9, 2023
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@matifali matifali enabled auto-merge (squash) October 9, 2023 07:10
@matifali
Copy link
Member Author

matifali commented Oct 9, 2023

@aslilac I think some recent changes cause what we are doing regarding displaying icons. Can you please take a look? I think we need to update make gen to consider newly added icons but I am not sure what command to add there.

@matifali matifali disabled auto-merge October 9, 2023 07:24
@aslilac
Copy link
Member

aslilac commented Oct 9, 2023

I already updated make gen, you just need to run it

@aslilac
Copy link
Member

aslilac commented Oct 9, 2023

can we use the file from here instead: https://github.com/hashicorp/vault/blob/main/ui/public/vault-logo.svg

issued under a known license, and we can just recolor it to their brand yellow

@matifali
Copy link
Member Author

matifali commented Oct 9, 2023

Hashicorp has both black and yello icons for the vault. Yellow looks better our dark UI. I guess it will be fine on the light UI too once we do it.

@matifali
Copy link
Member Author

matifali commented Oct 9, 2023

And I did run make gen but it didn't create any new file. I will try agin.

@aslilac
Copy link
Member

aslilac commented Oct 9, 2023

yeah but the one you used doesn't seem like it's from hashicorp, it contains some comment about another website I've never heard of. I'd rather not use one from an unknown source, we should use one we obtained from hashicorp. 😅

@aslilac
Copy link
Member

aslilac commented Oct 9, 2023

And I did run make gen but it didn't create any new file. I will try agin.

maybe try make -B gen

@matifali matifali enabled auto-merge (squash) October 9, 2023 18:19
@matifali matifali merged commit 2881b8b into main Oct 9, 2023
@matifali matifali deleted the add-vault-logo branch October 9, 2023 18:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants