Skip to content

fix: properly handle shebangs by writing files #10194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix: properly handle shebangs by writing files #10194

wants to merge 3 commits into from

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs requested a review from mafredri October 10, 2023 20:55
@kylecarbs kylecarbs self-assigned this Oct 10, 2023
mafredri
mafredri approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this! It's been on my todo(w)ish list for ages 😆

@github-actions github-actions bot added the stale This issue is like stale bread. label Oct 19, 2023
kylecarbs and others added 2 commits October 19, 2023 11:29
@kylecarbs @mafredri
Update agent/agent.go
883ccc7 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@kylecarbs @mafredri
Update agent/agentssh/agentssh.go
8f0257c 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@kylecarbs kylecarbs removed the stale This issue is like stale bread. label Oct 19, 2023
@kylecarbs kylecarbs enabled auto-merge (squash) October 19, 2023 16:30
@github-actions github-actions bot added the stale This issue is like stale bread. label Oct 27, 2023
@github-actions github-actions bot closed this Oct 30, 2023
auto-merge was automatically disabled October 30, 2023 00:10

Pull request was closed

@mafredri
Copy link
Member

I'm going to reopen this one @kylecarbs so it isn't forgotten!

@mafredri mafredri reopened this Oct 30, 2023
@github-actions github-actions bot removed the stale This issue is like stale bread. label Oct 31, 2023
@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 7, 2023
@matifali matifali removed the stale This issue is like stale bread. label Nov 9, 2023
@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 17, 2023
@github-actions github-actions bot closed this Nov 20, 2023
@matifali matifali reopened this Nov 20, 2023
@matifali matifali removed the stale This issue is like stale bread. label Nov 20, 2023
@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 28, 2023
@github-actions github-actions bot closed this Dec 1, 2023
@mafredri mafredri reopened this Dec 1, 2023
@github-actions github-actions bot removed the stale This issue is like stale bread. label Dec 2, 2023
@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 9, 2023
@github-actions github-actions bot closed this Dec 12, 2023
@kylecarbs kylecarbs reopened this Dec 12, 2023
@kylecarbs kylecarbs removed the stale This issue is like stale bread. label Dec 12, 2023
@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 20, 2023
@github-actions github-actions bot closed this Dec 23, 2023
@mafredri
Copy link
Member

mafredri commented Apr 9, 2024

@kylecarbs what do you want to do with this PR? I still think this would be a valuable addition so re-opening for now.

@mafredri mafredri reopened this Apr 9, 2024
@mafredri mafredri mentioned this pull request Apr 9, 2024
Closed
@matifali matifali removed the stale This issue is like stale bread. label Apr 9, 2024
@github-actions github-actions bot added the stale This issue is like stale bread. label Apr 17, 2024
@github-actions github-actions bot closed this Apr 21, 2024
@github-actions github-actions bot deleted the shebangfile branch April 21, 2024 00:05
@mafredri mafredri restored the shebangfile branch April 22, 2024 09:26
@mafredri mafredri removed the stale This issue is like stale bread. label Apr 22, 2024
@mafredri mafredri reopened this Apr 22, 2024
@github-actions github-actions bot added the stale This issue is like stale bread. label Apr 30, 2024
@github-actions github-actions bot closed this May 3, 2024
@github-actions github-actions bot deleted the shebangfile branch May 3, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@kylecarbs kylecarbs

Labels
stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @mafredri @matifali