feat: add all safe experiments to the deployment page #10276
Conversation
| {isEnabled && ( | ||
| <CheckCircleOutlined | ||
| sx={{ | ||
| width: 16, | ||
| height: 16, | ||
| color: (theme) => theme.palette.success.light, | ||
| margin: (theme) => theme.spacing(0, 1), | ||
| }} | ||
| /> |
There was a problem hiding this comment.
I like the check. If nothing is set though, it is tricky to know if nothing is set, or they are all set.
Can we do something to indicate the value is available, but not set? Like maybe greying out the words? Just one idea.
There was a problem hiding this comment.
Yeah! I like the design you've added above. I'll throw both in Slack and see what folks think.
There was a problem hiding this comment.
I actually kind of like either what I had previously, or what you suggested, but maybe not the mix of both as suggested in Slack.
|
If someone uses Also @bpmct what do you think about having a docs page on experiments that should at minimum, link to the experiment docs or describe what this experiment does? |
@matifali Yup! We list all experiments as being opted into if |
There was a problem hiding this comment.
TypeScript looks good to me! I can't comment on the Go code, but if @Emyrk didn't raise any issues from his review, I'm sure this PR is good to go
resolves #8978
Experiments will only appear in this list if they are safe to opt into.
I considered changing the response to the
experimentsendpoint, but it resulted in way more code and since there's been some back and forth about this feature I figured we'd just go with the simplest approach (a query param).