feat: add template setting to require active template version #10277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b0bf6d to
508a84d
Compare
spikecurtis
reviewed
Oct 16, 2023
spikecurtis
approved these changes
Oct 18, 2023
coderd/coderdtest/coderdtest.go
Outdated
| req := codersdk.CreateWorkspaceBuildRequest{ | ||
| // TODO (JonA): I get this is for convenience but we should probably | ||
| // change this. Tripped me up why my test was passing when it shouldn't | ||
| // have. |
There was a problem hiding this comment.
I don't really understand this comment --- change how?
There was a problem hiding this comment.
Currently the behavior when calling MustTransitionWorkspace is to submit a workspace build with the template's active version as opposed to the the workspace's template version. That's kinda at odds with how it behaves in production.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the backend plumbing to support enforcing workspaces use the active template version when buildling.
This setting does not apply to template admins
fixes #7466