Skip to content

feat: add telemetry for external provisioners #10322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat: add telemetry for external provisioners #10322

merged 2 commits into from
Oct 18, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Oct 17, 2023 •
edited
Loading

No telemetry server PR yet.

@coadler
Copy link
Contributor Author

coadler commented Oct 17, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@coadler coadler requested a review from ammario October 17, 2023 21:36
@coadler coadler linked an issue Oct 17, 2023 that may be closed by this pull request
external provisioners: report usage in telemetry #9556
Closed
ammario
ammario approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will have to be corresponding changes in the telemetry-server before this works. It's a bit janky so I can do it for you if you want.

@coadler coadler force-pushed the colin/feataddtelemetryforexternalprovisioners branch from 9ab248d to 1095daf Compare October 18, 2023 19:07
@coadler
Copy link
Contributor Author

coadler commented Oct 18, 2023

There will have to be corresponding changes in the telemetry-server before this works. It's a bit janky so I can do it for you if you want.

I'll have a PR up after I merge, although I'm mostly just copying what you did for CLI telemetry

@coadler coadler merged commit 504cedf into main Oct 18, 2023
@coadler coadler deleted the colin/feataddtelemetryforexternalprovisioners branch October 18, 2023 19:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ammario ammario ammario approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

external provisioners: report usage in telemetry
2 participants
@coadler @ammario