Skip to content

feat: add telemetry for external provisioners #10322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat: add telemetry for external provisioners #10322

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de1a365
feat: add telemetry for external provisioners
coadler Oct 17, 2023
1095daf
don't hash tag values
coadler Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
don't hash tag values
  • Loading branch information
@coadler
coadler committed Oct 18, 2023
commit 1095dafc10c8475fc79dff0edeab4974a01d6e06
8 changes: 3 additions & 5 deletions coderd/telemetry/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"bytes"
"context"
"crypto/sha256"
"encoding/hex"
"encoding/json"
"errors"
"fmt"
Expand Down Expand Up @@ -700,18 +699,17 @@ func ConvertWorkspaceProxy(proxy database.WorkspaceProxy) WorkspaceProxy {
}

func ConvertExternalProvisioner(id uuid.UUID, tags map[string]string, provisioners []database.ProvisionerType) ExternalProvisioner {
hashedTags := make(map[string]string, len(tags))
tagsCopy := make(map[string]string, len(tags))
for k, v := range tags {
hash := sha256.Sum256([]byte(v))
hashedTags[k] = hex.EncodeToString(hash[:])
tagsCopy[k] = v
}
strProvisioners := make([]string, 0, len(provisioners))
for _, prov := range provisioners {
strProvisioners = append(strProvisioners, string(prov))
}
return ExternalProvisioner{
ID: id.String(),
Tags: hashedTags,
Tags: tagsCopy,
Provisioners: strProvisioners,
StartedAt: time.Now(),
}
Expand Down