-
Notifications
You must be signed in to change notification settings - Fork 944
site: new dark theme #10331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site: new dark theme #10331
Conversation
🚀 Deploying PR 10331 ... |
Overall, this looks great! I think we have a couple of tweaks to make (like the audit log diff font color) but I know you're going through the snapshots so I won't compile a laundry-list here. LMK when stuff is cleaned up and I'll ✅ |
@@ -10,7 +10,7 @@ export const AuditPaywall: FC = () => { | |||
return ( | |||
<Paywall | |||
message="Audit logs" | |||
description="Audit Logs allows Auditors to monitor user operations in their deployment. To use this feature, you have to upgrade your account." | |||
description="Audit Logs allows Auditors to monitor user operations in their deployment. To use this feature, you need an Enterprise license." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin good!
Replace our old color palette with Tailwind colors
Start using the new experimental theme
roles
in a couple select placesSlim down the set of colors exposed in the theme/colors.ts
NewTheme
type that covers the vast majority of use cases.Eventually, we'll get rid of theme/colors.ts entirely, and replace the few remaining uses with just directly importing theme/tailwind.ts (and maybe we could rename that to colors.ts when the time comes)
Fix the background color that Storybook uses! It's been wrong this entire time!!
Some other minor reorganizing, add a few extra stories for stuff