Skip to content

site: new dark theme #10331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 15, 2023
Merged

site: new dark theme #10331

merged 15 commits into from
Nov 15, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Oct 18, 2023

  • Replace our old color palette with Tailwind colors

    • I did a bunch of math to map our old colors to the closest respective colors from the default Tailwind set, so they should all look good!
  • Start using the new experimental theme roles in a couple select places

  • Slim down the set of colors exposed in the theme/colors.ts

    • The idea is to quit using this module almost entirely, by exposing a much more curated set of colors in our NewTheme type that covers the vast majority of use cases.
  • Eventually, we'll get rid of theme/colors.ts entirely, and replace the few remaining uses with just directly importing theme/tailwind.ts (and maybe we could rename that to colors.ts when the time comes)

  • Fix the background color that Storybook uses! It's been wrong this entire time!!

  • Some other minor reorganizing, add a few extra stories for stuff

@aslilac aslilac changed the title refactor: themeing! refactor: experimental theming Oct 18, 2023
@aslilac aslilac changed the title refactor: experimental theming refactor: experiment with theming Oct 18, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023


🚀 Deploying PR 10331 ...

@github-actions github-actions bot added the stale This issue is like stale bread. label Oct 27, 2023
@github-actions github-actions bot closed this Oct 30, 2023
@aslilac aslilac reopened this Oct 30, 2023
@aslilac aslilac removed the stale This issue is like stale bread. label Oct 30, 2023
@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 7, 2023
@aslilac aslilac removed the stale This issue is like stale bread. label Nov 8, 2023
@aslilac aslilac changed the title refactor: experiment with theming refactor: replace our old palette with tailwind Nov 13, 2023
@aslilac aslilac requested review from a team and Kira-Pilot and removed request for a team November 13, 2023 18:50
@aslilac aslilac marked this pull request as ready for review November 13, 2023 18:51
@Kira-Pilot
Copy link
Member

Overall, this looks great! I think we have a couple of tweaks to make (like the audit log diff font color) but I know you're going through the snapshots so I won't compile a laundry-list here.

LMK when stuff is cleaned up and I'll ✅

@aslilac aslilac requested a review from Kira-Pilot November 15, 2023 20:27
@@ -10,7 +10,7 @@ export const AuditPaywall: FC = () => {
return (
<Paywall
message="Audit logs"
description="Audit Logs allows Auditors to monitor user operations in their deployment. To use this feature, you have to upgrade your account."
description="Audit Logs allows Auditors to monitor user operations in their deployment. To use this feature, you need an Enterprise license."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good!

@aslilac aslilac merged commit 8ddc8b3 into main Nov 15, 2023
@aslilac aslilac deleted the colorful branch November 15, 2023 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@aslilac aslilac changed the title refactor: replace our old palette with tailwind site: new dark theme Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants