Skip to content

chore: pin devcontainer.json to pre-nix image #10417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2023
Merged

chore: pin devcontainer.json to pre-nix image #10417

merged 4 commits into from
Nov 6, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Oct 30, 2023 •
edited
Loading

fixes #10416
this is a workaround, and it is tagged to an old version of an image.
While testing, it seems like --privileged is no longer required.

@matifali matifali marked this pull request as ready for review October 30, 2023 12:03
@matifali matifali requested a review from kylecarbs October 30, 2023 14:40
@matifali matifali changed the title chore: fix devcontainer.json chore: pin devcontainer.json to pre-nix image Oct 30, 2023
@matifali matifali added the hotfix label Nov 6, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@matifali matifali merged commit 55fb6b6 into main Nov 6, 2023
@matifali matifali deleted the devcontainer branch November 6, 2023 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.devcontainer is broken due to moby not available on Ubuntu Luner image
1 participant
@matifali