chore(coderd): add MockAuditor.Contains test helper #10421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Oct 30, 2023
| // Contains returns true if, for each non-zero-valued field in expected, | ||
| // there exists a corresponding audit log in the mock auditor that matches | ||
| // the expected values. Returns false otherwise. | ||
| func (a *MockAuditor) Contains(t testing.TB, expected database.AuditLog) bool { |
There was a problem hiding this comment.
Might be useful to be able to require multiple log entries and thus, also that the order is correct? Just a thought, feel free to disregard if it's premature.
There was a problem hiding this comment.
We could assert relative ordering perhaps, but asserting absolute ordering would likely run into the same kinds of issues we saw in #10396.
spikecurtis
approved these changes
Nov 1, 2023
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
4a95a79 to
f015c3c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10396
Contains()method onMockAuditorto help with asserting the presence of an audit log with specific fields.verifyAuditWorkspaceCreatedto use the new helper