-
Notifications
You must be signed in to change notification settings - Fork 888
chore(site): add remote playwright support and script #10445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even after reading the changes Idk how to use this, maybe you could add some docs about this in the docs/contributing/fe?
@BrunoQuaresma for instance, on your Mac:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was going to allow me to run the test on my workspace using the browser on my local machine but if this is an improvement, I'm up for it.
That's exactly what this does. |
Rephrase, I thought it would just require Chrome on my local machine. Having to set up the other things is what usually made it hard for me in the past to get it working. |
Because playwright decided to write their own API vs using plain Chrome DevTools Protocol. 😔 |
@BrunoQuaresma @mtojek I rewrote the script/setup a bit now, added docs, hopefully it's a bit clearer and easier to use. ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 You may want to record a demo and post it on slack :)
98377b0
to
4aff413
Compare
Got inspired to play around with this, and since I tried most of this out already, thought I'd make a PR.
I have no preference on the final implementation, so feel free to change this as you please.
Adds a new command
pnpm run playwright:remote
that starts a playwright server locally and opens up port forwards to the provided workspace and drops you into an SSH shell where you can start the test.(This relies on
config-ssh
to use plain OpenSSH to simplify things.)