Skip to content

chore(site): add remote playwright support and script #10445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 9, 2023
Merged

chore(site): add remote playwright support and script #10445

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
afd090d
chore(site): add playwright:remote script
mafredri Oct 31, 2023
9f7fe08
shfmt
mafredri Oct 31, 2023
d5a851e
exec
mafredri Oct 31, 2023
209f34c
rewrite script, now `scripts/remote_playwright.sh`
mafredri Nov 8, 2023
67c70b1
remove remote
mafredri Nov 8, 2023
4aff413
shellcheck
mafredri Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
shfmt
  • Loading branch information
@mafredri
mafredri committed Oct 31, 2023
commit 9f7fe08f53816634efecc1fa44c9769d60a2c2db
14 changes: 7 additions & 7 deletions site/e2e/server/run_with_forward.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ workspace=${1:-}
port=${2:-3000}

if [[ -z "${workspace}" ]]; then
echo "Usage: $0 <workspace> [port]"
exit 1
echo "Usage: $0 <workspace> [port]"
exit 1
fi

# Go to site.
Expand Down Expand Up @@ -36,11 +36,11 @@ rm "$playwright_out"

echo "Waiting for Playwright to start..."
read -r ws_endpoint <&3
if [[ ${ws_endpoint} != ws://* ]]; then
echo "Playwright failed to start."
echo "${ws_endpoint}"
cat "$playwright_out"
exit 1
if [[ ${ws_endpoint} != ws://* ]]; then
echo "Playwright failed to start."
echo "${ws_endpoint}"
cat "$playwright_out"
exit 1
fi
echo "Playwright started at ${ws_endpoint}"

Expand Down