Skip to content

refactor(site): handle edge cases for non-admin users with no workspaces and templates #10517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@coder/pm I would appreciate a review of the verbiage. You can also check the diffs on Storybook + Chromatic.

@BrunoQuaresma BrunoQuaresma self-assigned this Nov 3, 2023
@BrunoQuaresma BrunoQuaresma changed the title refactor(site): handle a few edge cases when ws and templates for a non admin user refactor(site): handle edge cases for non-admin users with no workspaces and templates Nov 3, 2023
@BrunoQuaresma BrunoQuaresma removed the request for review from bpmct November 3, 2023 23:07
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BrunoQuaresma BrunoQuaresma merged commit 5b9e26a into main Nov 6, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/improve-empty-workspaces-2 branch November 6, 2023 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants