fix: upgrade tailscale to fix STUN probes on dual stack #10535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
deansheather
approved these changes
Nov 6, 2023
3c432d4 to
0bdc2df
Compare
spikecurtis
commented
Nov 7, 2023
| @@ -69,9 +69,9 @@ func TestDERP(t *testing.T) { | |||
| assert.True(t, node.CanExchangeMessages) | |||
| assert.NotEmpty(t, node.RoundTripPing) | |||
| assert.Len(t, node.ClientLogs, 2) | |||
| assert.Len(t, node.ClientLogs[0], 1) | |||
| assert.Len(t, node.ClientLogs[0], 3) | |||
There was a problem hiding this comment.
note: extra logs come from coder/tailscale#41
spikecurtis
commented
Nov 7, 2023
| @@ -125,7 +127,7 @@ func TestDERP(t *testing.T) { | |||
| } | |||
| }) | |||
|
|
|||
| t.Run("ForceWebsockets", func(t *testing.T) { | |||
| t.Run("FailoverToWebsockets", func(t *testing.T) { | |||
There was a problem hiding this comment.
"ForceWebsockets" is a setting that makes it not even attempt regular DERP upgrade. Here we try Upgrade: DERP, get rejected, and then failover to websockets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes STUN probe issues on dual stack systems by incorporating coder/tailscale#43